Commits on Sep 28, 2015

1. Change multiselect cache structure …

   The existing structure used an Object as a cache where the keys are the
   values of option elements, and values are the HTML content of the option
   elements. In Javascript, if a numeric value in the form of a string is
   assigned as a key, it gets converted to an integer. Optimization
   routines would then order the object to ensure faster access to
   elements. For example:
   
   cache = {}
   cache['2'] = "two"
   cache['1'] = "one"
   console.log(cache[2])  #=> "two"
   console.log(cache[1])  #=> "one"
   console.log(cache)     #=> {1: "one", 2: "two"}
   
   Note the coercion of strings to ints above. This messes with the
   ordering of multiselect options list whenever there is a user input. To
   avoid this from happening, the keys need to have a string that can't be
   coerced automatically, and then preserve the value of the option
   element.
   
   I chose to use an object that stores the option value and the option
   HTML as the value of the cache and a string of the format 'o_<option
   value>' as the key. This ensures that the insertion order is preserved.
   This is the new structure:
   
   cache = {
     'o_271': { id: 271, value: 'CartItem railsadminteam#271'},
     'o_270': { id: 270, value: 'CartItem railsadminteam#270}'
   }

   

   meghaarora42 committed Sep 28, 2015
   Configuration menu

   • View commit details
   • Copy full SHA for 8afc20d
   • Browse repository at this point

   Copy the full SHA

   8afc20d View commit details

   Browse the repository at this point in the history