Swedish translation #270
Closed
Swedish translation #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joachim Nyqvist <Joachim@JNyqvist.se>
|
Tack. |
meghaarora42
added a commit
to meghaarora42/rails_admin
that referenced
this pull request
Sep 28, 2015
The exisiting structure used an Object as a cache where the keys are the
values of option elements, and values are the HTML content of the option
elements. In Javascript, if a numeric value in the form of a string is
assigned as a key, it gets converted to an integer. Optimization
routines would then order the object to ensure faster access to
elements. For example:
cache = {}
cache['2'] = "two"
cache['1'] = "one"
console.log(cache[2]) #=> "two"
console.log(cache[1]) #=> "one"
console.log(cache) #=> {1: "one", 2: "two"}
Note the coercion of strings to ints above. This messes with the
ordering of multiselect options list whenever there is a user input. To
avoid this from happening, the keys need to have a string that can't be
coerced automatically, and then preserve the value of the option
element.
I chose to use an object that stores the option value and the option
HTML as the value of the cache and a string of the format 'o_<option
value>' as the key. This ensures that the insertion order is preserved.
This is the new structure:
cache = {
'o_271': { id: 271, value: 'CartItem railsadminteam#271'},
'o_270': { id: 270, value: 'CartItem railsadminteam#270}'
}
meghaarora42
added a commit
to meghaarora42/rails_admin
that referenced
this pull request
Sep 28, 2015
The existing structure used an Object as a cache where the keys are the
values of option elements, and values are the HTML content of the option
elements. In Javascript, if a numeric value in the form of a string is
assigned as a key, it gets converted to an integer. Optimization
routines would then order the object to ensure faster access to
elements. For example:
cache = {}
cache['2'] = "two"
cache['1'] = "one"
console.log(cache[2]) #=> "two"
console.log(cache[1]) #=> "one"
console.log(cache) #=> {1: "one", 2: "two"}
Note the coercion of strings to ints above. This messes with the
ordering of multiselect options list whenever there is a user input. To
avoid this from happening, the keys need to have a string that can't be
coerced automatically, and then preserve the value of the option
element.
I chose to use an object that stores the option value and the option
HTML as the value of the cache and a string of the format 'o_<option
value>' as the key. This ensures that the insertion order is preserved.
This is the new structure:
cache = {
'o_271': { id: 271, value: 'CartItem railsadminteam#271'},
'o_270': { id: 270, value: 'CartItem railsadminteam#270}'
}
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added swedish translation.