Merge pull request #161 from krzysiek1507/improve_params

Serialize object with empty string value
railsware · Sep 10, 2015 · 05be832 · 05be832
2 parents 45bdbf8 + 6e766bd
commit 05be832
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/lib/routes.js b/lib/routes.js
@@ -28,7 +28,7 @@ Based on Rails routes of APP_CLASS
       if (prefix == null) {
         prefix = null;
       }
-      if (!object) {
+      if (object == null) {
         return "";
       }
       if (!prefix && !(this.get_object_type(object) === "object")) {
@@ -56,7 +56,7 @@ Based on Rails routes of APP_CLASS
           }
           break;
         default:
-          if (object) {
+          if (object != null) {
             s.push((encodeURIComponent(prefix.toString())) + "=" + (encodeURIComponent(object.toString())));
           }
       }

diff --git a/lib/routes.js.coffee b/lib/routes.js.coffee
@@ -16,7 +16,7 @@ NodeTypes = NODE_TYPES
 Utils =
 
   default_serializer: (object, prefix = null) ->
-    return ""  unless object
+    return "" unless object?
     if !prefix and !(@get_object_type(object) is "object")
       throw new Error("Url parameters should be a javascript hash")
 
@@ -30,7 +30,7 @@ Utils =
           key = "#{prefix}[#{key}]" if prefix?
           s.push @default_serializer(prop, key)
       else
-        if object
+        if object?
           s.push "#{encodeURIComponent(prefix.toString())}=#{encodeURIComponent(object.toString())}"
 
     return "" unless s.length

diff --git a/spec/js_routes/default_serializer_spec.rb b/spec/js_routes/default_serializer_spec.rb
@@ -5,8 +5,8 @@
   end
 
   it "should provide this method" do
-    expect(evaljs("Routes.default_serializer({a: 1, b: [2,3], c: {d: 4, e: 5}})")).to eq(
-      "a=1&b%5B%5D=2&b%5B%5D=3&c%5Bd%5D=4&c%5Be%5D=5"
+    expect(evaljs("Routes.default_serializer({a: 1, b: [2,3], c: {d: 4, e: 5}, f: ''})")).to eq(
+      "a=1&b%5B%5D=2&b%5B%5D=3&c%5Bd%5D=4&c%5Be%5D=5&f="
     )
   end
 

diff --git a/spec/js_routes/rails_routes_compatibility_spec.rb b/spec/js_routes/rails_routes_compatibility_spec.rb
@@ -74,6 +74,10 @@
     expect(evaljs("Routes.json_only_path({format: 'json'})")).to eq(routes.json_only_path(:format => 'json'))
   end
 
+  it "should serialize object with empty string value" do
+    expect(evaljs("Routes.inboxes_path({a: '', b: 1})")).to eq(routes.inboxes_path(:a => '', :b => 1))
+  end
+
   it "should support utf-8 route" do
     expect(evaljs("Routes.hello_path()")).to eq(routes.hello_path)
   end