Correct thread safety issue in js-routes generation

[alexaitken]

The reloading of routes during generation of js routes cause failures when multiple threads are including js-routes.

Error: RuntimeError: can't add a new key into hash during iteration
   (in /Users/alex/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/js-routes-0.9.6/app/assets/javascripts/js-routes.js.erb)

I believe this comes from calling Rails.application.reload_routes! while another thread is iterating the list of routes.

I have created an example application to show the issue. https://github.com/alexaitken/js_routes_failure

I removed the call to Rails.application.reload_routes! entirely. This change passes the tests and corrects the issue in the example application.

I found that the line Rails.application.reload_routes! was added back in commit 3f3dfda , but I am not sure what that change was solving. So this change may break something, that is not in the test suite.

[le0pard]

Hello, @alexaitken . How in tests used "config/routes.rb" file?

[alexaitken]

When we call Rails.application.initialize! it will load the config/routes.rb file.

Without a routes.rb load you will not see the thread safety issue.

If you check out at this commit a64e69c you can see the test failure.

Does that answer your question @le0pard ?

[le0pard]

Yep, this help. Thank you, @alexaitken. I just thinking, is it possible move this file inside spec directory?

[alexaitken]

@le0pard Turns out you can, I just pushed up the change.

[le0pard]

Thanks @alexaitken. Now all is perfect. Just need wait for @bogdan , because he is main contributor of project.

[alexaitken]

@le0pard Sounds good.