Install emacs-module.h when built with module support #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if one installs emacs-mac as 'brew install --with-modules emacs-mac', dynamic loading of modules will be enabled, but it won't be possible to actually build modules, because of the missing header dependency.
|
Thank you very much for your fix! I will merge it. |
|
Bump? |
|
Thanks for the PR. I will close it without merge, because this feature is already supported from upstream. I'm sorry for the long delay on response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one installs emacs-mac as 'brew install --with-modules emacs-mac',
dynamic loading of modules will be enabled, but it won't be possible to
actually build modules, because of the missing header dependency.
I've stumbled upon this problem when building https://github.com/akermu/emacs-libvterm against emacs-mac.