Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download path for hurl 4.30 #5

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

mystix
Copy link
Contributor

@mystix mystix commented Apr 30, 2024

@raimon49
Copy link
Owner

Oh, thank you!

We have a set of CI rules provided by the asdf team. We are being warned by the indentation of the additional code section. Could you please fix it?

 --- lib/utils.bash.orig
+++ lib/utils.bash
@@ -60,10 +60,10 @@
   (
     mkdir -p "$install_path"
     if ! $(echo -e "$version\n4.2.0" | sort -VC); then
-        # see https://github.com/Orange-OpenSource/hurl/issues/2401
-        cp -r "$ASDF_DOWNLOAD_PATH"/bin/* "$install_path"
+      # see https://github.com/Orange-OpenSource/hurl/issues/2401
+      cp -r "$ASDF_DOWNLOAD_PATH"/bin/* "$install_path"
     else
-        cp -r "$ASDF_DOWNLOAD_PATH"/* "$install_path"
+      cp -r "$ASDF_DOWNLOAD_PATH"/* "$install_path"
     fi
 
     local tool_cmd

fixed indentation
@mystix
Copy link
Contributor Author

mystix commented Apr 30, 2024

fixed indentation

@raimon49 raimon49 merged commit 473e2e9 into raimon49:main Apr 30, 2024
6 checks passed
@raimon49
Copy link
Owner

@mystix Thank you! I have a successful binary install in my environment 👍

$ asdf install hurl 4.3.0
* Downloading hurl release 4.3.0...
hurl 4.3.0 installation was successful!

$ asdf global hurl 4.3.0
$ hurl --version
hurl 4.3.0 (x86_64-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1f zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libssh/0.9.3/openssl/zlib nghttp2/1.40.0
Features (libcurl):  AsynchDNS brotli HTTP2 IDN IPv6 Largefile libz NTLM NTLM_WB SPNEGO SSL TLS-SRP UnixSockets
Features (built-in): brotli

@mystix
Copy link
Contributor Author

mystix commented Apr 30, 2024

Great! Thank you too!

@mystix mystix deleted the patch-1 branch April 30, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants