Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using trove/mixed as default license information source #60

Closed
johnthagen opened this issue Jan 25, 2020 · 2 comments
Closed

Comments

@johnthagen
Copy link
Contributor

johnthagen commented Jan 25, 2020

I've learned that trove classifiers are the preferred way to express license type information. See this note for explanation:

I believe that the current default for pip-licenses --from is not ideal (basically it always needs to be changed to get the best license information.

Would you consider changing the default to either trove or mixed? I personally feel mixed is the best default because it will provide the most comprehensive license information and prefer the correct source of truth (the troves).

I find this particularly compelling:

The license field is a text indicating the license covering the package where the license is not a selection from the “License” Trove classifiers. See the Classifier field. Notice that there’s a licence distribution option which is deprecated but still acts as an alias for license.

@johnthagen johnthagen changed the title Consider using trove classifiers as default license information source Consider using trove/mixed as default license information source Jan 25, 2020
@raimon49
Copy link
Owner

Yes, your opinion is correct.

pip-licenses started by outputting the license field, then supported the output of trove classifiers, and finally implemented mixed mode.

Currently, I think mixed mode can output the most desirable result.

However, changing the default behavior is a breaking change. I when to release a pip-licenses version 3.0, will probably adopt a mixed mode in default.

@johnthagen
Copy link
Contributor Author

However, changing the default behavior is a breaking change. I when to release a pip-licenses version 3.0, will probably adopt a mixed mode in default.

Agree, and that plan sounds great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants