Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.0 #77

Merged
merged 11 commits into from
Oct 25, 2020
Merged

Release 3.0.0 #77

merged 11 commits into from
Oct 25, 2020

Conversation

raimon49
Copy link
Owner

@raimon49 raimon49 commented Aug 24, 2020

Release version of v-3.0.0

Key changes and goals

Task list

  • Complete major changes
  • Documentation updates and reviews
  • Bump version
  • Release to TestPyPI
  • Release to PyPI

* Update dependencies pinned policy for support Python 3.5
* Clarified support for Python 3.9
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files           1        1           
  Lines         338      338           
=======================================
  Hits          333      333           
  Misses          5        5           
Impacted Files Coverage Δ
piplicenses.py 98.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5cf53c...7908092. Read the comment docs.

@johnthagen
Copy link
Contributor

# XXX: Use enum when drop support Python 2.7

You could use an enum here given Python 2.7 is no longer supported.

@johnthagen
Copy link
Contributor

Another possible idea is to use type hints to make the functions in this piplicenses.py a little easier to understand. See PEP 484.

This also has the added benefits that editors such as PyCharm and VS Code will provide more auto-complete/inspection when contributors are working on the code base.

@johnthagen johnthagen mentioned this pull request Aug 30, 2020
9 tasks
@@ -81,7 +81,7 @@ Execute the command with your venv (or virtualenv) environment.

### Option: from

By default, this tool finds the license from package Metadata (`--from=meta`). However, depending on the type of package, it does not declare a license only in the Classifiers.
By default, this tool finds the license from [Trove Classifiers](https://pypi.org/classifiers/) or package Metadata. Some Python packages declare their license only in Trove Classifiers.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since pip-licenses 3.0, mixed mode is the standard behavior.

This is an acceptance of Proposal #60, because mixed mode is more convenient for many users.

Comment on lines -10 to +12
pytest-pycodestyle<2.1 # Pinned for Python 3.5
pytest-pycodestyle
pytest-runner
twine<2 # Pinned for Python 3.5
twine
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping support for Python 3.5 eliminates the need for pinning.

@raimon49 raimon49 marked this pull request as ready for review October 25, 2020 01:29
@raimon49 raimon49 changed the title [WIP] Release 3.0.0 Release 3.0.0 Oct 25, 2020
@raimon49
Copy link
Owner Author

The packages released by TestPyPI seem to be working well.
https://test.pypi.org/project/pip-licenses/3.0.0/

@raimon49
Copy link
Owner Author

The release to PyPI is complete.
https://pypi.org/project/pip-licenses/3.0.0/

@raimon49 raimon49 merged commit 650dfc2 into master Oct 25, 2020
@raimon49 raimon49 deleted the release-3.0.0 branch October 25, 2020 01:42
@johnthagen
Copy link
Contributor

We've been using 3.0.0 and it's been working great. The new default --from=mixed has allowed us to simplify a bunch of scripts that run pip-licenses. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants