Keeping slippage fixed at 50 bips #1744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were not being precise about the concepts of price impact and slippage.
We should keep the slippage fixed at the same default Uniswap uses (0.5% or 50 bips). In the future, we may include UI to allow users to update the slippage they are comfortable with.
Please note that this is separate from "price impact" which is taken into account in the execution price we provide to the user.