Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BalanceCoinRow into FastBalanceCoinRow and FastCoinIcon #3313
Refactor BalanceCoinRow into FastBalanceCoinRow and FastCoinIcon #3313
Changes from 50 commits
044a9e2
5a57e58
3715a8e
05732e7
902f9c6
a58e9f5
5d335af
931a5e9
455a8ea
c3dce23
4b7e3cd
dcb194b
22cebb8
04e3c38
b8946ec
ab0ebb0
97af3de
69180b3
7a97f85
fca4811
0c297aa
622cc09
4f12ace
4c93242
8318e3c
ee76c40
c2e9586
6259fa9
5a3e79b
d9de929
88f5418
308cf99
bed39b3
35c5439
3be86a6
dcd7127
184f7be
076d180
a6b116c
80ad782
e4ad7ea
ba0400a
4ae584d
ba799ea
a17f6ff
e466d89
93fc8f6
8b92467
2c60b35
9c1fa51
380ce43
bf7e450
9417548
2b00268
b8ee401
d40e1bd
322fee7
4763506
d6f5165
0f968da
996443a
1798c57
d055486
bea48fd
d535fc4
1e7ba12
daddb29
346e1df
dc8b19c
281d715
33d2af8
b3c64c8
a32f3a9
2511ce4
0613972
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use a different name than
cx
? I have a hard time knowing what is it about. I think I already changed something about thesz
in animated styles in another componentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cx is actually a really popular name for such things if you've ever used css-modules in react.
but yeah I'll consider something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think cx is ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is some kind of react convention, then great I didn't know that