wallet connect fix #5387
Merged
wallet connect fix #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/model/migrations.ts
Outdated
| *************** Migration v19 ****************** | ||
| Purge walletconnect v2 sessions with no accounts | ||
| */ | ||
| const v19 = async () => { |
There was a problem hiding this comment.
can we add this to the new migrations flow that our king @estrattonbailey made? wanna deleeet these at some point
There was a problem hiding this comment.
totally forgot that existed lol
There was a problem hiding this comment.
am I having a stroke or did I respond to a notification like this months ago lmao
miss you guysssss ❤️
There was a problem hiding this comment.
@estrattonbailey !!!!!
hope all is well over at bsky
There was a problem hiding this comment.
ill never miss a chance to tag my king
benisgold
force-pushed
the
@benisgold/wc-fix
branch
from
68a70ea
to
41a83e5
Compare
walmat
approved these changes
Feb 7, 2024
benisgold
commented
Feb 7, 2024
| @@ -270,13 +270,8 @@ export default function WalletConnectApprovalSheet() { | |||
| const handleConnect = useCallback(() => { | |||
| handled.current = true; | |||
| goBack(); | |||
| if (IS_IOS) { | |||
There was a problem hiding this comment.
moved this inside wc approval callback. i noticed that this was causing the "connection successful" modal to pop up even if there was an error
skylarbarrera
added
the
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1129
What changed (plus any additional context for devs)
Screen recordings / screenshots
UI for connections w/o supported networks
failed + successful dapp connections
https://github.com/rainbow-me/rainbow/assets/15272675/fa31a4fc-8890-46c8-9c74-7e4fe141b654
https://github.com/rainbow-me/rainbow/assets/15272675/25bf5524-8db3-4f54-a9e3-b8468577bdae
What to test
TF 1.9.15 (27)
try connecting to https://devnet.dymension.xyz/rollapps and then navigating to connected dapps list