chore: reduce imgix usage - nfts #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benisgold
reviewed
Feb 20, 2024
src/utils/handleNFTImages.ts
Outdated
| w: isGIF ? cardSize : FULL_NFT_IMAGE_SIZE, | ||
| })) ?? null; | ||
| : url?.startsWith?.(GOOGLE_USER_CONTENT_URL) | ||
| ? url.replace(/=s\d+$/, `?s=${FULL_NFT_IMAGE_SIZE}`) |
There was a problem hiding this comment.
i cant remember the context exactly, but i think i removed the google url stuff bc urls that did not end in ?s={size} were not getting resized
There was a problem hiding this comment.
good call out ill add a case for that
There was a problem hiding this comment.
looks like out initial logic was wrong at some point to and we were not resizing the images properly, google may have changed the param structure
im unable to find a url that doesnt have on a few wallets with my upcoming change so we should be good
benisgold
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1169
What changed (plus any additional context for devs)
we may need to revisit the lowResUrls and make sure we are signing gifs ✅
Screen recordings / screenshots
What to test
NFTs should load and display properly