Add backend provided slippage #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
requested review from
benisgold,
skylarbarrera and
jinchung
as code owners
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@rainbow-me/swaps@0.16.0 |
skylarbarrera
approved these changes
Apr 22, 2024
| /** | ||
| * NOTE: Before executing a swap, we want to check several things: | ||
| * 1. assetToSell && assetToBuy addresses match the quote values | ||
| * 2. outputNative matches quote value |
There was a problem hiding this comment.
this check makes sense but not sure if practical, like isnt there a case where the quote could update
There was a problem hiding this comment.
outputNative is updated when the quote updates
There was a problem hiding this comment.
Probably not a necessary check, but is more of a sanity check that the user is displayed and can confirm what will actually get received.
BrodyHughes
added a commit
that referenced
this pull request
May 7, 2024
…eplink-add * 'develop' of github.com:rainbow-me/rainbow: simplify logic for fee display (#5660) zustand: use smol subscriptions (#5661) useSyncSharedValue (#5662) handle wc links in browser (#5652) Add default error page (#5657) update firebase (#5636) browser: fix android card images (#5651) Add backend provided slippage (#5649) Add rainbow fee to review panel (#5650) review prompt changes (#5656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1357
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test