Add default error page #5657
Merged
Add default error page #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylarbarrera
approved these changes
Apr 22, 2024
| import lang from 'i18n-js'; | ||
| import React from 'react'; | ||
| import { Centered } from '../layout'; | ||
| import { Text } from '../text'; |
There was a problem hiding this comment.
you're playing with fire
There was a problem hiding this comment.
I heard you're great at making new screens
benisgold
approved these changes
Apr 22, 2024
That's a good point. For most errors it won't be recoverable so the current copy isn't ideal. Do you have any suggestion? |
walmat
reviewed
Apr 23, 2024
walmat
reviewed
Apr 23, 2024
walmat
reviewed
Apr 23, 2024
walmat
reviewed
Apr 23, 2024
Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>
Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>
Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>
BrodyHughes
added a commit
that referenced
this pull request
May 7, 2024
…eplink-add * 'develop' of github.com:rainbow-me/rainbow: simplify logic for fee display (#5660) zustand: use smol subscriptions (#5661) useSyncSharedValue (#5662) handle wc links in browser (#5652) Add default error page (#5657) update firebase (#5636) browser: fix android card images (#5651) Add backend provided slippage (#5649) Add rainbow fee to review panel (#5650) review prompt changes (#5656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
Screen recordings / screenshots
Screen.Recording.2024-04-22.at.5.25.00.PM.mov
What to test