APP-1500 #5763
Merged
APP-1500 #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
May 23, 2024
src/screens/SignTransactionSheet.tsx
Outdated
| @@ -950,6 +950,7 @@ export const SignTransactionSheet = () => { | |||
| } | |||
| newShadows | |||
| onPress={submitFn} | |||
| disabled={!walletBalance?.isLoaded || !selectedGasFee.gasFee.estimatedFee} | |||
There was a problem hiding this comment.
are there any other cases where this should be disabled? If so, I think we should move this out to a functional check.
What should happen if the tx simulation hasn't resolved yet? Should we disable the button during that?
There was a problem hiding this comment.
i think people should be able to transact if they choose to without waiting for sim since it's not vital
benisgold
commented
May 23, 2024
| @@ -769,6 +769,8 @@ export const SignTransactionSheet = () => { | |||
|
|
|||
| const expandedCardBottomInset = EXPANDED_CARD_BOTTOM_INSET + (isMessageRequest ? 0 : GAS_BUTTON_SPACE); | |||
|
|
|||
| const canPressConfirm = isMessageRequest || (!!walletBalance?.isLoaded && !!currentNetwork && !!selectedGasFee?.gasFee?.estimatedFee); | |||
There was a problem hiding this comment.
if just message signing we dont need to wait for these things
walmat
approved these changes
May 23, 2024
|
/tf |
|
/testflight |
greg-schrammel
pushed a commit
that referenced
this pull request
May 24, 2024
* fix * optional chaining just in case * allow message signing tx w/o loaded balance/gas
walmat
added a commit
that referenced
this pull request
May 24, 2024
* types improvements * useSwapsStore * number & currency formatter * gasss * dont keep previous data * use chainId from input token * hm * decimal separator * add gas fee to review panel * 😕 * save * fix (#5758) * consolidated verified assets fetches (#5759) * fix (#5761) * chore: i18n updates (#5762) * APP-1500 (#5763) * fix * optional chaining just in case * allow message signing tx w/o loaded balance/gas * aaaaaa * uhu * add border back to review gas button * remove color todo tags * gasPrice --------- Co-authored-by: Matthew Wall <matthew.wallt@gmail.com> Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> Co-authored-by: Daniel Sinclair <d@niel.nyc>
BrodyHughes
added a commit
that referenced
this pull request
May 28, 2024
…licious-dapp-warning-e2e * 'develop' of github.com:rainbow-me/rainbow: Swaps: package upgrades, fix SwapBackground and AnimatedSwapSpinner (#5775) Swaps: fix safe math negative number support, add comparison functions (#5776) Reanimated v3.11.0 (#5683) Gas (#5757) add degen chain to network selector (#5766) prefer local chain image over custom (#5772) add safe math fns (#5765) filter out assets from curated assets with no icon_url (#5768) fix isQuoteStale lag (#5769) fix icon sizing (#5771) Preliminary work: Update formatter functions to take in object params (#5760) APP-1500 (#5763) chore: i18n updates (#5762)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1500
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test