Filter curated assets to only ones with icon_url #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benisgold
reviewed
May 24, 2024
| @@ -75,7 +76,7 @@ export function useSearchCurrencyLists() { | |||
| // static search data | |||
| const { data: verifiedAssets, isLoading: verifiedAssetsLoading } = useTokenSearch( | |||
| { list: 'verifiedAssets' }, | |||
| { staleTime: 60 * 60 * 1000, cacheTime: 24 * 60 * 60 * 1000 } | |||
| { select: filterNonTokenIconAssets, staleTime: 60 * 60 * 1000, cacheTime: 24 * 60 * 60 * 1000 } | |||
There was a problem hiding this comment.
two questions:
- should we apply this filter to the other search queries (target verified/unverified)?
- should this filter be at the response parsing level instead of selector level? assuming we will use the verifiedAssets elsewhere in the app, maybe we'd want the same standard of data completeness (must have icon url) everywhere in the app
There was a problem hiding this comment.
- No. We only want this requirement for curated assets. Verified / Unverified assets should be able to not have this in case a user searches for a specific token.
- Again related to Supporting default transaction (non ETH and non token transfer) #1, but I think we only want this for the static curated assets list
benisgold
approved these changes
May 24, 2024
BrodyHughes
added a commit
that referenced
this pull request
May 28, 2024
…licious-dapp-warning-e2e * 'develop' of github.com:rainbow-me/rainbow: Swaps: package upgrades, fix SwapBackground and AnimatedSwapSpinner (#5775) Swaps: fix safe math negative number support, add comparison functions (#5776) Reanimated v3.11.0 (#5683) Gas (#5757) add degen chain to network selector (#5766) prefer local chain image over custom (#5772) add safe math fns (#5765) filter out assets from curated assets with no icon_url (#5768) fix isQuoteStale lag (#5769) fix icon sizing (#5771) Preliminary work: Update formatter functions to take in object params (#5760) APP-1500 (#5763) chore: i18n updates (#5762)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RNBW-4727
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test