Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points UI #5866

Merged
merged 46 commits into from
Jun 24, 2024
Merged

Points UI #5866

merged 46 commits into from
Jun 24, 2024

Conversation

christianbaroni
Copy link
Member

@christianbaroni christianbaroni commented Jun 18, 2024

What changed (plus any additional context for devs)

  • Adds new Points UI
  • Enables P3 color on iOS via react-native and react-native-linear-gradient patches (allows for richer colors)
  • Bumps Skia and Reanimated to latest versions — should fix a couple of Android crashes/errors coming from Reanimated
  • Fixes the longstanding bug that sometimes prevented the switch wallet sheet from being scrollable

Todo:

  • i18n
  • Add last few missing UI states
  • Feature flag

Screen recordings / screenshots

What to test

Copy link

socket-security bot commented Jun 18, 2024

@christianbaroni christianbaroni marked this pull request as ready for review June 21, 2024 21:58
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jinchung jinchung merged commit ae5e687 into develop Jun 24, 2024
6 checks passed
@jinchung jinchung deleted the @christian/points-ui branch June 24, 2024 04:14
BrodyHughes added a commit that referenced this pull request Jun 26, 2024
…able-unit-tests

* 'develop' of github.com:rainbow-me/rainbow:
  rerun only failed tests (#5878)
  bump versions to v1.9.28 (#5893)
  input asset regression fix on v1 (#5891)
  bump to version 1.9.27 (#5890)
  take into account l1 op  gas fee for claimBridge (#5889)
  Points UI (#5866)
  Remove input value typeof checks (#5886)
  Fix swap button presses, adjust button state logic (#5884)
  Swaps: Gas fee range to use for native asset maxSwappableAmount buffer (#5881)
  clear custom gas settings (#5875)
  Review button states (#5854)
  fix handler (#5880)
  Use graphql ens key everywhere (#5882)
  Fix chain badges on android (#5867)
  fix android padding calc (#5877)
  add unknown type as failed (#5871)
  Swaps: gas icons, review sheet cleanup (#5872)
  Swap flashbots min priority fee (#5869)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants