fix android padding calc #5877
Merged
fix android padding calc #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimtaveras00
approved these changes
Jun 20, 2024
BrodyHughes
added a commit
that referenced
this pull request
Jun 26, 2024
…able-unit-tests * 'develop' of github.com:rainbow-me/rainbow: rerun only failed tests (#5878) bump versions to v1.9.28 (#5893) input asset regression fix on v1 (#5891) bump to version 1.9.27 (#5890) take into account l1 op gas fee for claimBridge (#5889) Points UI (#5866) Remove input value typeof checks (#5886) Fix swap button presses, adjust button state logic (#5884) Swaps: Gas fee range to use for native asset maxSwappableAmount buffer (#5881) clear custom gas settings (#5875) Review button states (#5854) fix handler (#5880) Use graphql ens key everywhere (#5882) Fix chain badges on android (#5867) fix android padding calc (#5877) add unknown type as failed (#5871) Swaps: gas icons, review sheet cleanup (#5872) Swap flashbots min priority fee (#5869)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
We were asumming all android phones have the softMenu enabled and that's not the case for my Pixel 4.
I've added a check and adjusted the padding accordingly.
Screen recordings / screenshots
BEFORE
AFTER
What to test