Copy/Paste fixes #5953
Merged
Copy/Paste fixes #5953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
Jul 25, 2024
jinchung
requested changes
Jul 25, 2024
+1, would rather we address the underlying issue making the extra wrapper necessary, if it is actually necessary currently |
it is not being used so I removed the event arg on gesture handler v1 callbacks |
greg-schrammel
commented
Jul 30, 2024
Comment on lines
-75
to
+80
| onStart: e => { | ||
| if (onPressStartWorklet) onPressStartWorklet(e); | ||
| onStart: () => { | ||
| if (onPressStartWorklet) onPressStartWorklet(); | ||
| }, | ||
| onActive: e => { | ||
| if (onPressWorklet) onPressWorklet(e); | ||
| if (onPressJS) runOnJS(onPressJS)(e); | ||
| onActive: () => { | ||
| if (onPressWorklet) onPressWorklet(); | ||
| if (onPressJS) runOnJS(onPressJS)(); |
There was a problem hiding this comment.
these e were not used anywhere
walmat
approved these changes
Aug 2, 2024
christianbaroni
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
inputMethodto the right field on pasteonPresscalls the handler with theeventand this event was being passed as arg to those functions, making they misbehaveScreen recordings / screenshots
What to test