-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Degen Mode, swap settings panel #5963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianbaroni
requested review from
brunobar79,
jinchung,
greg-schrammel and
walmat
July 27, 2024 22:35
Leaves one instance of GestureHandlerV1Button in SwapSlider because it relies on the ref prop
Previously, the default slippage value was set only once when the swap UI was initially mounted — it wasn't being updated when the input asset network was changed. Now, if the user hasn't overridden the default value, slippage will update to the correct default when the input asset network changes.
walmat
approved these changes
Jul 29, 2024
BrodyHughes
added a commit
that referenced
this pull request
Aug 1, 2024
…inbow into brody/enable-android-tests * 'brody/enable-android-tests' of github.com:rainbow-me/rainbow: degen mode feature flag (#5969) Fix Android dapp browser gestures (#5964) Add Degen Mode, swap settings panel (#5963) Update flipping logic in SwapInputsController (#5948) Hold to swap button (#5920)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1677
What changed (plus any additional context for devs)
Auto
ChainContextMenu
componentGestureHandlerV1Button
toGestureHandlerButton
(RNGH v1 → v2)GestureHandlerV1Button
inSwapSlider
because it relies on theref
prop3_homeScreen
e2e test and increases the max number of parallel workers, which speeds up tests a bitScreen recordings / screenshots
RPReplay_Final1722110339.MP4
What to test