Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hold to press reliability #5967

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Improve hold to press reliability #5967

merged 3 commits into from
Jul 30, 2024

Conversation

christianbaroni
Copy link
Member

@christianbaroni christianbaroni commented Jul 30, 2024 •
edited
Loading

Fixes APP-1643

What changed (plus any additional context for devs)

  • Prevents intermittent states where tapping can incorrectly trigger submitting a swap

Screen recordings / screenshots

What to test

@linear Linear
Copy link

linear bot commented Jul 30, 2024

APP-1643 Fetching button not disabled, able to proceed to review

walmat
walmat approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with this, but it might be easier to just create a const enum if we're gonna cast a bunch of things to as const

@christianbaroni christianbaroni merged commit 552a660 into develop Jul 30, 2024
6 checks passed
@christianbaroni christianbaroni deleted the @christian/hold-to-press-improvements branch July 30, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-schrammel greg-schrammel greg-schrammel approved these changes

@walmat walmat walmat approved these changes

@jinchung jinchung Awaiting requested review from jinchung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christianbaroni @greg-schrammel @walmat