index favorites by uniqueId instead of address #5972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-schrammel
commented
Jul 31, 2024
| const query = useQuery({ | ||
| queryKey: favoritesQueryKey, | ||
| queryFn: refreshFavorites, | ||
| staleTime: 24 * 60 * 60 * 1000, // 24hrs |
There was a problem hiding this comment.
instead of refetching every time the app loads, refresh once after 24hrs stale
greg-schrammel
commented
Jul 31, 2024
|
|
||
| const updatedMetadataByNetwork = await Promise.all( | ||
| Object.entries(favoritesByNetwork).map(async ([network, networkFavorites]) => | ||
| fetchMetadata(networkFavorites, ethereumUtils.getChainIdFromNetwork(network as Network)) |
There was a problem hiding this comment.
this splits the tokens that don't have a mainnet address to fetchMetadata from their network instead
like the case for degen
greg-schrammel
requested review from
brunobar79,
walmat,
BrodyHughes,
ibrahimtaveras00 and
jinchung
walmat
reviewed
Jul 31, 2024
walmat
reviewed
Jul 31, 2024
walmat
reviewed
Jul 31, 2024
walmat
reviewed
Jul 31, 2024
walmat
requested changes
Jul 31, 2024
walmat
approved these changes
Aug 2, 2024
ibrahimtaveras00
added a commit
that referenced
this pull request
Aug 5, 2024
This reverts commit 6d28cfc.
ibrahimtaveras00
pushed a commit
that referenced
this pull request
Aug 7, 2024
* 👍 * migration * add networks placeholder to default favorites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1683 APP-1676
What changed (plus any additional context for devs)
we can't store based on just the address because for example the degen token in the degen network is address zero, same we use sometimes for eth in mainnet, found lots of lil weird bugs like that I think this fixes it all, probably good to QA this one
Screen recordings / screenshots
What to test