Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: await connectWallet for walletbutton #1890

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Conversation

jguyton
Copy link
Contributor

@jguyton jguyton commented Mar 26, 2024

What changed:

  • updated WalletButtonRendererProps connect type to be a Promise matching the handler returned
  • await connectWallet promise during connect

@jguyton jguyton requested a review from a team as a code owner March 26, 2024 17:26
Copy link

vercel bot commented Mar 26, 2024

@jguyton is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@magiziz magiziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 6:13pm
rainbowkit-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 6:13pm

@DanielSinclair DanielSinclair changed the title [trivial] await connectWallet and update connect prop type to promise fix: await connectWallet for walletbutton Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants