Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if chain switching is not support by mobile wallet, show message to end user #272

Merged
merged 4 commits into from
Apr 27, 2022
Merged

fix: if chain switching is not support by mobile wallet, show message to end user #272

merged 4 commits into from
Apr 27, 2022

Conversation

nickbytes
Copy link
Contributor

@nickbytes nickbytes commented Apr 27, 2022 •
edited
Loading

  • Some wallets do not support programmatic chain switching
    • to check for this, we need to see if switchNetwork (from wagmi) is undefined
    • if so, we need to show a message to users in the chain switch modal that their wallet is not able to switch chains
    • this feels like a better approach than hiding the chain switching modal, because users might want to know their wallet is not using all possible capabilities.
  • need better designed state here

@vercel
Copy link

vercel bot commented Apr 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rainbowkit-example ✅ Ready (Inspect) Visit Preview Apr 27, 2022 at 4:38PM (UTC)
rainbowkit-site ✅ Ready (Inspect) Visit Preview Apr 27, 2022 at 4:38PM (UTC)

@nickbytes nickbytes changed the title wip: debugging fix: debugging chain switching Apr 27, 2022
@nickbytes nickbytes changed the title fix: debugging chain switching fix: if chain switching is not support by mobile wallet, show message to end user Apr 27, 2022
@nickbytes nickbytes marked this pull request as ready for review April 27, 2022 16:55
@nickbytes nickbytes requested a review from a team as a code owner April 27, 2022 16:55
nicoglennon
nicoglennon approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@nicoglennon nicoglennon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my lord and savior

@nickbytes nickbytes merged commit 6052e20 into main Apr 27, 2022
@nickbytes
Copy link
Contributor Author

lmao

@nickbytes nickbytes deleted the @nickbytes/debugging-chain-switching branch April 27, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoglennon nicoglennon nicoglennon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickbytes @nicoglennon