Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When packages are listed without an explicit version number, this crashes npm-check-updates #52

Closed
GerHobbelt opened this issue Feb 16, 2015 · 0 comments

Comments

@GerHobbelt
Copy link
Contributor

Tested with both 1.5.1 and 2.0.0beta6: running npm-check-updates -u in a directory which contains this package.json:

{
  "name": "na",
  "description": "not relevant.",
  "version": "0.1.0",
  "devDependencies": {
    "cjson": "^0.3.0",
    "docco": "git://github.com/GerHobbelt/docco.git#gh-pages",
    "event-stream": "",
    "gulp": "",
    "gulp-closure-compiler": "",
    "gulp-compressor": "",
    "gulp-concat": "",
    "gulp-exec": "",
    "gulp-file-include": "",
    "gulp-insert": "",
    "gulp-jison": "git://github.com/GerHobbelt/gulp-jison.git#master",
    "gulp-jsbeautifier": "",
    "gulp-karma": "",
    "gulp-less": "",
    "gulp-manifest": "",
    "gulp-replace": "",
    "gulp-run": "^1.6.6",
    "gulp-util": "^3.0.3",
    "gulp-yuicompressor": "",
    "jasmine-core": "^2.2.0",
    "jsdoc": "git://github.com/GerHobbelt/jsdoc.git#master",
    "karma-chrome-launcher": "^0.1.7",
    "karma-jasmine": "^0.3.5",
    "mkdirp": "^0.5.0",
    "through2": "^0.6.3",
    "yargs": ""
  }
}
GerHobbelt referenced this issue in GerHobbelt/npm-check-updates Feb 16, 2015
Now npm-check-updates properly skips the `#master` branch/git repository entries in the `package.json` and it skips any entries in `package.json` which are non-standard (i.e. contain no version at all or list an invalid version such as `0.1`)
raineorshine added a commit that referenced this issue Feb 16, 2015
Ignore modules with invalid versions that fail the semver lookup. Fixes #51 and #52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants