Expose ncurc retrieval to programmatic API #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raineorshine
requested changes
Oct 5, 2019
…geFile` for calculation of config file cwd (over default `process.cwd`)
|
I've applied the changes, including the breaking change for the CLI. |
|
Published in I published as a patch as the default path was clearly a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this with some programmatic usage, and thought it best for your other consumers not to have to duplicate this or resort to the CLI to get ncurc retrieval logic.
One breaking change I did not make (though I made it easier to implement if you want to go that route), but which I think would be useful--allow the rcLoader current working directory to be based by default on the directory of
packageFile, since they would presumably usually be in the same (project root) directory.