Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 refactoring #587

Merged
merged 2 commits into from
Oct 7, 2019
Merged

ES6 refactoring #587

merged 2 commits into from
Oct 7, 2019

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Oct 6, 2019

  • refactor: Use more ES6 features (array destructuring, rest params, includes, array extras, Object values/entries); concat args
  • Add recommended "json" extension to eslintrc

Just some minor updates and refactoring to minimize dependencies where the standard is about equivalent.

brettz9 and others added 2 commits October 6, 2019 08:18
…`includes`, array extras, Object values/entries); `concat` args

- Add recommended "json" extension to `eslintrc`
@raineorshine
Copy link
Owner

Thanks for helping to improve the codebase! That's a big help!

@raineorshine raineorshine merged commit 3fc7aaf into raineorshine:master Oct 7, 2019
@raineorshine
Copy link
Owner

Published in v3.1.24

@brettz9 brettz9 deleted the es6 branch October 7, 2019 02:32
@brettz9
Copy link
Contributor Author

brettz9 commented Oct 7, 2019

Thanks for reviewing and merging, no less so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants