Jsdoc #588
Merged
Jsdoc #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add some types/return values)
…ix` function as function does not later allow a non-object anyways - Minor refactoring: Avoid else after throw
|
Greater specificity could be added for some of the types, but I figure that could be added as time goes on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsdoctags and casing, denoting optional items (and add some types/return values)optionscheck innpm.js'defaultPrefixfunction as function does not later allow a non-object anywaysThere is still one non-standard jsdoc-style tag you have in place (
@sideeffects), but I didn't change that as there is no standard equivalent (there is a@modifiestag, but that is for side effects on objects) and JSDoc does allow custom tags.