Translate attributes / indexes not cleared when model is deleted

[acasar]

Translatable attributes/indexes are not removed from the database after a parent model is deleted, which can cause issues in some situations when using transWhere.

This was already reported (#211), but I am reopening the issue, since it has not been resolved and it's causing our production apps to fail in unexpected ways

[daftspunk]

Correct me if I'm wrong, but could this be caused by 508c42c since it happens across two separate queries now. One idea is to use GC to clean up orphaned records.

[acasar]

That's true, when implementing 508c42c I was not aware that translation tables contain orphaned records by design. But I think that a cleanup of related translated records in beforeDelete event should solve this issue?

[daftspunk]

Yes, if you are happy with that, let's hook afterDelete inside \RainLab\Translate\Behaviors\TranslatableModel to clean up orphaned indexes.

public function __construct($model)
{
    parent::__construct($model);

    // ...

    $model->bindEvent('model.afterDelete', [$this, 'cleanupTranslatableData']);
}

[acasar]

If anyone else is interested, I fixed this by extending the base model:

$model->bindEvent('model.beforeDelete', function() use ($model) {
    if($model->isClassExtendedWith('RainLab.Translate.Behaviors.TranslatableModel')) {
        DB::table('rainlab_translate_attributes')
            ->where('model_id', $model->getKey())
            ->where('model_type', get_class($model))
            ->delete();
        DB::table('rainlab_translate_indexes')
            ->where('model_id', $model->getKey())
            ->where('model_type', get_class($model))
            ->delete();
    }
});

And I also added a console command to clean existing orphaned records.

[daftspunk]

Looks good, native integration added to the behavior here: d4eb433

Thanks @acasar!