[playframework#1304] Binder does not check if id field is null

rajit · Dec 12, 2011 · 2bb3801 · 2bb3801
1 parent 29dea1d
commit 2bb3801
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/framework/src/play/db/jpa/JPAPlugin.java b/framework/src/play/db/jpa/JPAPlugin.java
@@ -83,8 +83,8 @@ public Object bind(RootParamNode rootParamNode, String name, Class clazz, java.l
                     Class[] pk = new JPAModelLoader(clazz).keyTypes();
                     int j = 0;
                     for (ParamNode id : ids) {
-                        if (id.getValues() == null || id.getValues().length == 0) {
-                            // We have no ids, it is a new entity
+                        if (id.getValues() == null || id.getValues().length == 0 || id.getFirstValue(null)== null || id.getFirstValue(null).trim().length() <= 0 ) {
+                             // We have no ids, it is a new entity
                             return GenericModel.create(rootParamNode, name, clazz, annotations);
                         }
                         query.setParameter(j + 1, Binder.directBind(id.getOriginalKey(), annotations, id.getValues()[0], pk[j++], null));