Add rake tasks for files added to spec.files by a cross_compile block #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! |
|
I am working on an updated commit with unit tests soon. |
sodabrew
force-pushed
the
cross_compile_spec_files
branch
from
5a859be
to
073faa1
Compare
|
Factored out a helper method, added a unit test, here's an example where I need this functionality: https://github.com/brianmario/mysql2/blob/master/tasks/compile.rake#L30 |
kou
added a commit
that referenced
this pull request
Jan 3, 2015
Add rake tasks for files added to spec.files by a cross_compile block Patch by Aaron Stone. Thanks!!!
|
Thanks for adding a test! |
|
Thank you! Works great with rake-compiler 0.9.5! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #98. Note that this code duplicates a block of code in
define_compile_tasks. I could split it out to a private separate method.