Don't use --release flag on Java 8 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Mar 29, 2023
lib/rake/javaextensiontask.rb
Outdated
| @@ -303,5 +303,9 @@ def java_lint_arg | |||
|
|
|||
| "-Xlint:#{@lint_option}" | |||
| end | |||
|
|
|||
| def release_flag_supported? | |||
| !(RUBY_PLATFORM =~ /java/) || Gem::Version.new(Java::java.lang.System.getProperty('java.version')) >= Gem::Version.new("9") | |||
There was a problem hiding this comment.
Could you use early return for readability?
Suggested change
| !(RUBY_PLATFORM =~ /java/) || Gem::Version.new(Java::java.lang.System.getProperty('java.version')) >= Gem::Version.new("9") | |
| return false unless /java/match?(RUBY_PLATFORM) | |
| Gem::Version.new(Java::java.lang.System.getProperty('java.version')) >= Gem::Version.new("9") |
There was a problem hiding this comment.
I guess I can't use match? because this gem is still ruby 1.8 compatible :) but sure, I'll change it...
There was a problem hiding this comment.
We can drop support for Ruby 1.8 because we can't test with it.
There was a problem hiding this comment.
ok, but it's for a separate PR, what should be the minimum version?
Closed
This was referenced Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows using
on Java 8 (for building the gem), because the flag is available since Java 9, see https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html
this flag is for backward compatibility, so it's safe to just skip it if we can't use it.
relates to puma/puma#3109 socketry/nio4r#292