Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop ruby < 2.5 support #214

Closed
wants to merge 1 commit into from
Closed

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Mar 29, 2023

this PR drops support for long EOL rubies as suggested by #213 (comment)

some gems still support very old versions, but I think Ruby 2.5 should be a reasonable minimum. This version is also currently tested by Github actions.

required_ruby_version = '>= 2.5.0'

it also applies rubocop autocorrect for Ruby 2.5 feature level (just styling)

@konsolebox
Copy link
Contributor

konsolebox commented Mar 30, 2023

Please consider having 2.0 as minimum instead. I'm proud of having my gems support 2.2 even though the version is already EOL. I don't want to change dependency parameters just because of this.

Also it doesn't make sense to include style alterations in same commit.

Lastly, isn't using =~ instead of match? good enough?

@kou
Copy link
Member

kou commented Mar 30, 2023

it also applies rubocop autocorrect for Ruby 2.5 feature level (just styling)

Could you revert them? It adds many needles diffs.

Please consider having 2.0 as minimum instead. I'm proud of having my gems support 2.2 even though the version is already EOL. I don't want to change dependency parameters just because of this.

Could you explain why do you want to support Ruby 2.2?
For example, I maintain test-unit and it supports old Rubies as much as possible (including Ruby 2.1: https://github.com/test-unit/test-unit/blob/master/.github/workflows/test.yml ) to support migration from an old Ruby to a recent Ruby. Upgrading Ruby itself and testing framework at the same time is difficult. So I want to support "old Ruby + old testing framework" -> "old Ruby + new testing framework" -> "new Ruby + new testing framework" migration path.

@konsolebox
Copy link
Contributor

Could you explain why do you want to support Ruby 2.2?

2.2 is simply the minimum version my gems needed. They were first released on that version and I simply didn't have any reason to upgrade.

2.2 if I recall right made significant ext-related changes that made me decide to start with it instead of 2.0 or 2.1.

I don't even have compatibility hacks in my code and my 2.2 tests still succeed.

@ahorek ahorek closed this Mar 30, 2023
@kou
Copy link
Member

kou commented Mar 30, 2023

I see. Thanks.

@ahorek
Copy link
Contributor Author

ahorek commented Mar 30, 2023

@kou I understand the maintenance burden, there're still people using it for ancient stuff... if it doesn't break we shouldn't touch it without a strong reason...

@kou
Copy link
Member

kou commented Mar 30, 2023

I agree with you.
Note that we don't want to support EOL-ed Rubies actively for rake-compiler. If we need to create a shim for EOL-ed Rubies, we'll drop support for EOL-ed Rubies instead of creating a shim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants