Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark this library as deprecated and give a better alternative in README #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

japsu
Copy link

@japsu japsu commented Mar 14, 2017

This library is no longer required on Node.js due to the fact that the socket.io-client library nowadays has built-in support for setting extra headers such as cookies:

const io = require('socket.io-client');

const cookie = 'connect.sid=xyz';
const socket = io(url, { path, extraHeaders: { cookie } });

This is documented in the underlying engine.io-client library:

https://github.com/socketio/engine.io-client#nodejs-with-extraheaders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant