-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GPS location and automatic location detection along with accuracy #29
Conversation
it seems working. better to display accurate place name instead of latlong |
Can be easily done using But not sure if there is a daily API limit (As google maps APIs went rigorous with pricing |
Can't you request the google api from client side? |
That will mostly be IP based or cookie based. So if you request from client side, they won't hit the limit. |
No. I still can access the URL: And get the correct response, but not when running from localhost. So it is probably domain based and not client IP or Cookie based. |
GoogleMaps APIs no longer work without a key, we would need one to call their geo-coding APIs. |
Added this using Nominatim API which uses OpenStreetMap, Seems to be working fine, do check the new commit. |
Require testing before merge @vigneshhari |
I think we need to increase the timeout and maximum age. |
Merged and deployed to production |
2700 meters accuracy for me |
Are you trying from mobile or desktop? I have removed the timeout and maximumAge in #89 . Do merge that as well, otherwise Accurate GPS will not be fetched before timeout. |
This PR adds automatic GPS location fetching for devices with GPS support and stores it in the database.
Also added is a "Open in maps" button for request list which directly opens the location in google maps
model fields added -
view edited -
html changes -