Prevent loss of m_ipv6_socket attribute #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SocketFd::accept()
always returnsSocketFd
object withm_ipv6_socket
flag set to false.As the result
SocketFd::set_priority()
which called later on the same socket executeseven for IPv6 sockets.
Linux tolerates this, but on FreeBSD such call on IPv6 socket cause error, and as the result following call chain fails:
what causes immediate drop of any incoming connection right after it has been accept()-ed.
Syscall trace of this case on FreeBSD host:
For comparison same trace on CentOS 7 host:
This change fixes rakshasa/rtorrent#786