Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exception on latest rtorrent (commit 4353f1bfa8686a177088822fdebc9909782154f6) #13

Closed
artifexor opened this issue Dec 10, 2011 · 5 comments

Comments

@artifexor
Copy link

I've got the following exception: "rtorrent: priority_queue_insert(...) called on an already queued item"

I am using FreeBSD 8.2.

@rakshasa
Copy link
Owner

e0e654f fixes a couple of potential issues, however without a proper backtrace I can't determine if the issue above has been fixed.

@artifexor
Copy link
Author

Compiled and no exception yet.

For a proper backtrace might this help.

http://stackoverflow.com/questions/2443135/how-do-i-find-where-an-exception-was-thrown-in-c

http://mykospark.net/2009/09/runtime-backtrace-in-c-with-name-demangling/

If the examples are right it means that backtrace is automatic at exception and does not need gdb.

@rakshasa
Copy link
Owner

Several places in the code use exceptions for non-critical error handling, and as such catching them all will not work.

Instead, replace the exception in rak/priority_queue_default.h with an exit call, which gdb will break on automatically.

@artifexor
Copy link
Author

Thanks for the hint. I think it's better if a program is self descriptive on errors than need to use gdb. It's not a must but debugging might be easier. I do not start rtorrent from gdb all the time and I had exception that I cannot repeat under gdb so the information was gone.

@rakshasa
Copy link
Owner

Yeah, but there's no clean way of providing backtraces from exceptions, so I'll leave it at that for the moment. Fixed the obvious potential causes of this bug so closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants