New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils: lockfile: avoid stack overflow for lockfile buffer #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to have been some change on openSUSE (likely some new hardening flags for builds, or some glibc hardening) such that incorrect buffer handling results in a segfault even if the buffer is never overflowed. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Here's the key info from the coredump:
I suspect this is caused by |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 23, 2022
https://build.opensuse.org/request/show/984398 by user jengelh + dimstar_suse - Backport fix which resolves a crashing issue on startup on openSUSE. rakshasa/rtorrent#1169 + 0001-utils-lockfile-avoid-stack-overflow-for-lockfile-buf.patch
Note that this is actually with |
stickz
added a commit
to stickz/swizzin
that referenced
this pull request
Apr 4, 2023
Backports fix for lock file crash merged into rTorrent master. rakshasa/rtorrent#1169
stickz
added a commit
to stickz/swizzin
that referenced
this pull request
Apr 4, 2023
Backports fix for lock file crash merged into rTorrent master. rakshasa/rtorrent#1169
liaralabs
pushed a commit
to swizzin/swizzin
that referenced
this pull request
Apr 11, 2023
Backports fix for lock file crash merged into rTorrent master. rakshasa/rtorrent#1169
Elegant996
added a commit
to Elegant996/rtorrent
that referenced
this pull request
May 15, 2023
Elegant996
added a commit
to Elegant996/rtorrent
that referenced
this pull request
May 23, 2023
crabtw
added a commit
to crabtw/nix-system-config
that referenced
this pull request
Jul 17, 2023
vamega
pushed a commit
to vamega/rtorrent
that referenced
this pull request
Jul 19, 2023
Original patch by @cyphar was submitted to rakshasa/rtorrent at rakshasa/rtorrent#1169. Observed the segfault on nixos-unstable.
This was referenced Jul 19, 2023
Elegant996
added a commit
to Elegant996/rtorrent
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to have been some change on openSUSE (likely some new
hardening flags for builds, or some glibc hardening) such that incorrect
buffer handling results in a segfault even if the buffer is never
overflowed.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com