Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display values of multiple throttle.up and throttle.down in the first part of status bar #480

Merged
merged 1 commit into from Aug 1, 2019

Conversation

chros73
Copy link
Contributor

@chros73 chros73 commented Aug 7, 2016

Display values of multiple throttle.up and throttle.down in the first part of status bar, also change name of config directive.

Currently the beginning of status bar looks like this:
[Throttle 500/1500 KB] [Rate: 441.6/981.3 KB]

Include the max limit of the throttles, the main upload rate and the upload rate of the throttles (in this order); and main download rate and the download rate of the selected throttles.

Possible cases look like these:

[Throttle 200 / 500 KB] [Rate 107.4 / 298.6 KB]
[Throttle 200(114) / 500 KB] [Rate 107.0(1.0|105.9) / 307.6 KB]
[Throttle 200 / 500(250) KB] [Rate 124.7 / 298.2(298.2|0.0) KB]
[Throttle 200(114) / 500(250) KB] [Rate 115.9(1.7|114.2) / 333.9(333.9|0.0) KB]

[Throttle 3500(75|25) / 8000 KB] [Rate 1745.5(1635.1|85.0|25.4) /   7.3 KB]
  • make the displayable throttle names configurable via config file: ui.status.throttle.up.set and ui.status.throttle.down.set
  • original code is refactored
  • throttle.up and throttle.down values can be specified simultanously (as in the last example)
  • name of throttles must be specified without surrounding quotes (the setting no longer a string but a list)
    • ui.status.throttle.up.set = slowup , tardyup
    • ui.status.throttle.down.set = slowup
  • limitation is that every group (there are 4 possible groups) can contain the following number of characters (it leaves space for at least 5 throttles to be displayed):
    • limit: 40 chars
    • rate: 50 chars
  • don't display this extra info of a given throttle in the following cases:
    • there isn't any throttle name as the config variables suggest or the given name is "NULL"
    • the throttle is not throttled (=0)
    • the global upload/download is not throttled (=0) (the throttle won't be taken into account in this case)

Refers to: #447 , #564 (comment)

@chros73
Copy link
Contributor Author

chros73 commented Mar 6, 2017

I want to modify this one next, to be able to set/display multiple throttle groups.

@chros73
Copy link
Contributor Author

chros73 commented Apr 19, 2017

I have modified the pull request (updated the description as well), major changes are:

  • original code is refactored
  • name of the config variables are changed to: ui.status.throttle.up.set and ui.status.throttle.down.set
  • name of throttles must be specified without surrounding quotes (the setting is no longer a string but a list)
    • ui.status.throttle.up.set = slowup , tardyup
    • ui.status.throttle.down.set = slowup
  • limitation is that every group (there are 4 possible groups) can contain the following number of characters (it leaves space for at least 5 throttles to be displayed):
    • limit: 40 chars
    • rate: 50 chars

Enjoy!

@chros73 chros73 changed the title Display values of 1 throttle.up and 1 throttle.down in the first part of status bar Display values of multiple throttle.up and throttle.down in the first part of status bar Apr 19, 2017
@chros73
Copy link
Contributor Author

chros73 commented Jul 19, 2019

@rakshasa : Thanks for the new release!
I'll update my pending PRs on the current releases in the upcoming weeks, if I'll have time.

@chros73
Copy link
Contributor Author

chros73 commented Jul 27, 2019

I'll update my pending PRs on the current releases

Only this one had problems, so I rebased it on current master and solved the merge conflicts.
All my other patches are fine, no need to rebase them.

@rakshasa, it would be really nice of you if you would merge these, so I wouldn't have to do this one more time :) Thanks!
And you can try these features/fixes out using the new release of rtorrent-ps-ch.

@rakshasa rakshasa merged commit f22475d into rakshasa:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants