Skip to content

Commit

Permalink
Explicitly set the use_gold GN variable.
Browse files Browse the repository at this point in the history
So far we were assuming ld.gold was always present and preferred. While this
tends not to be an issue and upstream only tests gold in its builds (it's
faster and uses less memory), we need to respect the ld-is-gold
DISTRO_FEATURE.

Doing so also helps when building the native bits, as gold's presence in the
host system is less likely than in the target toolchain.

Signed-off-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
  • Loading branch information
rakuco committed Sep 22, 2017
1 parent 206770c commit e7cfbf6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions recipes-browser/chromium/chromium_61.0.3163.100.bb
Expand Up @@ -208,6 +208,7 @@ GN_ARGS += '\
is_clang=false \
linux_use_bundled_binutils=false \
target_cpu="${@gn_arch_name('${TUNE_ARCH}')}" \
use_gold=${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', 'true', 'false', d)} \
v8_snapshot_toolchain="//build/toolchain/yocto:yocto_target" \
'

Expand Down

0 comments on commit e7cfbf6

Please sign in to comment.