Improve tipping logic for self."!private"()

Don't suggest `self!"private"()` if no private candidates found.
rakudo · Jul 23, 2020 · 760034e · 760034e
1 parent b36afcb
commit 760034e
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/core.c/Exception.pm6 b/src/core.c/Exception.pm6
@@ -170,11 +170,6 @@ my class X::Method::NotFound is Exception {
         my @tips;
         my $indirect-method = "";
 
-        if $.method.starts-with("!") && !$.private {
-            $indirect-method = $.method.substr(1);
-            @tips.push: "Method name starts with '!', did you mean 'self!\"$indirect-method\"()'?";
-        }
-
         my %suggestions;
         my int $max_length = do given $.method.chars {
             when 0..3 { 1 }
@@ -220,6 +215,11 @@ my class X::Method::NotFound is Exception {
             }
         }
 
+        if $.method.starts-with("!") && !$.private && $private_suggested {
+            $indirect-method = $.method.substr(1);
+            @tips.push: "Method name starts with '!', did you mean 'self!\"$indirect-method\"()'?";
+        }
+
         if +%suggestions == 1 {
             @tips.push: "Did you mean '%suggestions.keys()'?";
         }