Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline::Perl5 integration tests are no longer run #2815

Closed
lizmat opened this issue Apr 5, 2019 · 8 comments · Fixed by #3796 or #3797
Closed

Inline::Perl5 integration tests are no longer run #2815

lizmat opened this issue Apr 5, 2019 · 8 comments · Fixed by #3796 or #3797

Comments

@lizmat
Copy link
Contributor

lizmat commented Apr 5, 2019

It appears that since the relocatable build refactor, make spectest is no longer running the Inline::Perl5 integration tests, even though Inline::Perl5 is installed.

@AlexDaniel AlexDaniel added the BLOCKER Preventing the next release of rakudo, or just needing attention before the release label Apr 5, 2019
@lizmat lizmat removed the BLOCKER Preventing the next release of rakudo, or just needing attention before the release label Apr 21, 2019
@lizmat
Copy link
Contributor Author

lizmat commented Apr 21, 2019

I don't think this is a blocker. Hopefully, we'll fix this at the PTS

@coke
Copy link
Collaborator

coke commented Jul 14, 2020

I'm seeing what may be a related issue:

make spectest

...

Inline::Perl5 not installed: not running Perl 5 integration tests
You can install Inline::Perl5 into the build directory with

    zef --install-to=inst#/Volumes/BUKKIT/Users/coke/sandbox/rakudo/t/../gen/build_rakudo_home/site install Inline::Perl5

but if I run this zef command, it tells me all the candidates are currently installed, and then rerunning the spectest shows the same error.

@vendethiel
Copy link
Contributor

it tells me all the candidates are currently installed

That's an issue with zef --install-to= I think, which doesn't use only that path to check if a module is installed. So if the module is installed somewhere else on your machine, zef --install-to= doesn't actually do something useful.

@coke
Copy link
Collaborator

coke commented Jul 14, 2020

FYI, added "--force-install" to that zef command, it installed... and then I got the same error from spectest, it's still not installed.

@ugexe
Copy link
Member

ugexe commented Jul 14, 2020

@coke Can you try adding the --contained flag ala:
zef --contained --install-to=inst#/Volumes/BUKKIT/Users/coke/sandbox/rakudo/t/../gen/build_rakudo_home/site install Inline::Perl5?

--contained (BETA)      Install all transitive and direct dependencies regardless if they are already installed globally

Note that its BETA because it can have some issues installing to an existing repository (which it looks like you might be doing, but maybe it'll work).

EDIT: actually n/m... if you got it to force install then the above isn't going to get you any further.

@ugexe
Copy link
Member

ugexe commented Jul 14, 2020

make spectest with Inline::Perl5 works if manually set the lib -- RAKULIB="inst#/Users/ugexe/repos/rakudo/t/../gen/build_rakudo_home/site" make spectest after using the zef install instructions. Something in make spectest should be setting that if it is going to tell users to install stuff to a specific location.

@vrurg
Copy link
Member

vrurg commented Jul 15, 2020

All spectest targets in Makefile are using t/harnessN scripts. I think they're the best place for the fix.

vrurg added a commit to vrurg/rakudo that referenced this issue Jul 17, 2020
Fixes rakudo#2815. The problem occurs when the module is installed in the
system rakudo repository. Fix as suggested by @ugexe in
rakudo#2815 (comment)
vrurg added a commit to vrurg/rakudo that referenced this issue Jul 17, 2020
Fixes rakudo#2815. The problem occurs when the module is installed in the
system rakudo repository. Fix as suggested by @ugexe in
rakudo#2815 (comment)
@patrickbkr
Copy link
Contributor

The original solution to this problem was to set the RAKUDO_HOME env var in the build runners in tools/templates/moar/rakudo-m-build.c.in. I'm wonder why that didn't have an effect (anymore?). Thus I'm not sure modifying the harness scripts is the correct fix...

@patrickbkr patrickbkr reopened this Jul 17, 2020
patrickbkr added a commit to patrickbkr/rakudo that referenced this issue Jul 17, 2020
So one can still influence the Rakudo home even with non-relocatable Rakudo
builds.

This fixes rakudo#2815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants