Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakudo home env precedence #3797

Merged
merged 2 commits into from Jul 17, 2020

Conversation

patrickbkr
Copy link
Contributor

The precedence of the different RAKUDO_HOME sources was wrong. A static rakudo home set by Configure in every non-relocatable build was most dominant and thus couldn't be overridden with an environment variable anymore. That makes little sense. It also broke spec tests using Inline-Perl5 using the build runners, because the build runner relies on the RAKUDO_HOME env variable to set a different rakudo home.

This fixes #2815.

This reverts commit 847dd8d, reversing
changes made to 37d5831.

Proper fix follows.
So one can still influence the Rakudo home even with non-relocatable Rakudo
builds.

This fixes rakudo#2815
@patrickbkr patrickbkr requested a review from vrurg July 17, 2020 08:26
Copy link
Member

@vrurg vrurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we didn't think of it in first place!

@patrickbkr patrickbkr merged commit 4a115c4 into rakudo:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline::Perl5 integration tests are no longer run
2 participants