[WIP] Blin 2019-08-20 #3132

AlexDaniel · 2019-08-22T11:37:32Z

AlexDaniel · 2019-08-22T11:56:58Z

There's a golf for c7056f2 issues here: c7056f2#commitcomment-34749749

salortiz · 2019-08-22T21:45:58Z

@AlexDaniel,
The issue with c7056f2 was fixed with 0dd6573
Regards.

AlexDaniel · 2019-08-22T21:48:05Z

Yes, got that! Thank you!

AlexDaniel · 2019-08-29T16:22:07Z

From the last Blin run:

API::USNavalObservatory – Fail, Bisected: 43066b9
App::AizuOnlineJudge – Fail, Bisected: 43066b9
App::Assixt – Fail, Bisected: 43066b9
App::Tasks – Fail, Bisected: 43066b9
Audio::Icecast – Fail, Bisected: 43066b9
Config::Parser::yaml – Fail, Bisected: 43066b9
Cro::Core – Fail, Bisected: 43066b9
Cro::HTTP::Test – Fail, Bisected: 43066b9
Cro::OpenAPI::RoutesFromDefinition – Fail, Bisected: 43066b9
Cro::RPC::JSON – Fail, Bisected: 43066b9
Cro::WebApp – Fail, Bisected: 43066b9
CroX::HTTP::FallbackPassthru – Fail, Bisected: 43066b9
FanFou – Fail, Bisected: 43066b9
Hastebin – Fail, Bisected: 43066b9
I18n::Simple – Fail, Bisected: 43066b9
LogP6 – Fail, Bisected: 43066b9
LogP6-Writer-Journald – Fail, Bisected: 43066b9
Magento – Fail, Bisected: 43066b9
Monitor::Monit – Fail, Bisected: 43066b9
Net::Telnet – Fail, Bisected: 43066b9
Oddmuse6 – Fail, Bisected: 43066b9
OpenAPI::Model – Fail, Bisected: 43066b9
Sparrow6 – Fail, Bisected: 43066b9
Template::Classic – Fail, Bisected: 43066b9
Test::HTTP::Server – Fail, Bisected: 43066b9
Tomtit – Fail, Bisected: 43066b9
Tomty – Fail, Bisected: 43066b9
WebService::Soundcloud – Fail, Bisected: 43066b9

Ping @vrurg.

Blin output: https://usercontent.irccloud-cdn.com/file/FuRvVGH3/blin-output-2019-08-29.tar.gz

<japhb> AlexDaniel: Not looking at the tarball, but if you're seeing a lot of failed installs, it might be because YAMLish won't install right now. Author is aware.
<japhb> Leont/yamlish#29

There are many modules depending on YAMLish, but YAMLish was bisected to a different commit (c7056f2), but issues in that commit were already fixed, so it's just a bisection detail.

AlexDaniel · 2019-08-29T16:28:26Z

Something related to grammar .parse:

RDF::Turtle – Fail, Bisected: b21a577
DNS::Zone – Fail, Bisected: b21a577
TAP – Fail, Bisected: b21a577

jnthn · 2019-08-29T16:31:10Z

About 43066b9, I mentioned when the 6.e grammar base class was being discussed that there should also be another meta-class (a 6.e GrammarHOW), which the 6.e BOOTSTRAP can then configure with the 6.e Grammar. That meta-class can go either in BOOTSTRAP or even in the 6.e setting. That would avoid this issue. Trying to do it with the approach taken here is not going to end well.

AlexDaniel · 2019-08-29T16:32:17Z

Other bisected modules, but these may be a bit spurious:

CoreHackers::Sourcery – Fail, Bisected: c94f5db
Cro::WebSocket – Fail, Bisected: 38aa128
Grammar::PrettyErrors – Fail, Bisected: da65fb5
Proc::Q – Fail, Bisected: f53c828

vrurg · 2019-08-29T16:58:23Z

I think most of the problems related to 43066b9 are caused by broken TAP module. I already know what's the problem is.

@jnthn I would still be in favor of avoiding version-specific metaclasses.

jnthn · 2019-08-29T21:34:59Z

I think most of the problems related to 43066b9 are caused by broken TAP module. I already know what's the problem is.

I think they're all because we find the wrong Grammar, because it's perfectly fine (and even fairly common) for modules to use that name within a module, and so have it registered lexically.

I would still be in favor of avoiding version-specific metaclasses.

Why? If we did that, we'd not have the problem exhibited here. And, more deeply, it feels entirely right to me: the default parent is a meta-behavior, and if we're already having another version of a behavior, I don't see why we shouldn't have another version of the related meta-behavior too.

vrurg · 2019-08-29T23:51:53Z

I think they're all because we find the wrong Grammar, because it's perfectly fine (and even fairly common) for modules to use that name within a module, and so have it registered lexically.

Aha. I had to limit symbol lookup to setting, but used lexical lookup on client.

Why? If we did that, we'd not have the problem exhibited here. And, more deeply, it feels entirely right to me: the default parent is a meta-behavior, and if we're already having another version of a behavior, I don't see why we shouldn't have another version of the related meta-behavior too.

Perl6::Metaclass::Grammar6eHOW? Definitely not.

Language-specific meta? Should be possible, but not yet supported by the build subsystem. I have started process of merging common parts of moar and jvm makefiles and it turns out to be even more time consuming than I expected.

But otherwise the first thing coming to my mind is Perl6::Metamodel::v6<rev> and use Perl6::Metamodel::v6<rev>; in revision's BOOTSTRAP.

vrurg · 2019-08-30T02:53:19Z

vrurg · 2019-08-30T14:51:23Z

#3154 fixes all reported modules except for Grammar::PrettyErrors. I will merge the PR and then proceed with the latter. Though due to approaching hurricane not sure how much time would I have these days.

AlexDaniel · 2019-08-30T15:41:32Z

Thank you, @vrurg! Please take care.

vrurg · 2019-08-31T22:57:13Z

Re-implementing #3154 to conform with @jnthn request. Thus, all module checks would be re-done.

It must be possible to create grammars named `Grammar` rakudo/rakudo#3132

vrurg · 2019-09-01T18:12:54Z

Grammar::PrettyErrors got a PR bduggan/raku-grammar-prettyerrors#1

vrurg · 2019-09-02T01:36:06Z

All failures fixed with c757ada and with the above mentioned PR.

Test for 6.e grammar `Grammar` name It must be possible to create grammars named `Grammar` rakudo/rakudo#3132

AlexDaniel · 2019-09-06T13:47:01Z

Here are the latest results. Seems previous issues are not resolved? @vrurg, can you check?

Raw data: https://usercontent.irccloud-cdn.com/file/WWEU5lHe/blin-output-2019-09-06.tar.gz

ASN::META – Fail, Bisected: 2ee82af
Cro::WebSocket – Fail, Bisected: 38aa128

DNS::Zone – Fail, Bisected: b21a577
RDF::Turtle – Fail, Bisected: b21a577
TAP – Fail, Bisected: b21a577

URI::Template – Fail, Bisected: c7056f2
YAMLish – Fail, Bisected: c7056f2

CoreHackers::Sourcery – Fail, Bisected: c94f5db
Grammar::PrettyErrors – Fail, Bisected: da65fb5
Proc::Q – Fail, Bisected: f53c828
Unicode::GCB – Fail, Bisected: f5ef0b3

vrurg · 2019-09-06T14:53:08Z

@AlexDaniel check if it was ran against HEAD and there was no mistake. Cro::Core on freshly build HEAD from official repo, not the fork of mine:

🅸 ttys000 vrurg@beetle ~/s/P/c/cro-core ⇒ prove6 -l                                                                                                                                                                                                                                                                                                           -1- 06-09-19 10:49:49 [master]
t/composer.t ................ ok
t/connection-conditional.t .. ok
t/connection-state.t ........ ok
t/iri.t ..................... ok
t/mediatype.t ............... ok
t/message-with-body.t ....... ok
t/tcp.t ..................... ok
t/uri.t ..................... ok
All tests successful.
Files=8, Tests=1164,  11 wallclock secs
Result: PASS

There must be something else.

AlexDaniel · 2019-10-03T08:49:53Z

@vrurg thank you for your work!

It's time for a new ticket.

AlexDaniel added the BLOCKER Preventing the next release of rakudo, or just needing attention before the release label Aug 22, 2019

AlexDaniel mentioned this issue Aug 22, 2019

[WIP] Blin 2019-08-08 #3113

Closed

8 tasks

vrurg added a commit to vrurg/roast that referenced this issue Sep 1, 2019

Test for 6.e grammar Grammar name

e506e8c

It must be possible to create grammars named `Grammar` rakudo/rakudo#3132

vrurg added a commit to vrurg/roast that referenced this issue Sep 1, 2019

Test for 6.e grammar Grammar name

d3c737a

It must be possible to create grammars named `Grammar` rakudo/rakudo#3132

vrurg mentioned this issue Sep 1, 2019

Test for 6.e grammar Grammar name Raku/roast#573

Merged

vrurg added a commit to Raku/roast that referenced this issue Sep 2, 2019

Merge pull request #573 from vrurg/rakudo_3132

d19f6ae

Test for 6.e grammar `Grammar` name It must be possible to create grammars named `Grammar` rakudo/rakudo#3132

AlexDaniel closed this as completed Oct 3, 2019

AlexDaniel added the blin Result of a regular ecosystem check with modules regressed, which must be fixed before release label Jun 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Blin 2019-08-20 #3132

[WIP] Blin 2019-08-20 #3132

AlexDaniel commented Aug 22, 2019 •

edited

Loading

AlexDaniel commented Aug 22, 2019

salortiz commented Aug 22, 2019

AlexDaniel commented Aug 22, 2019

AlexDaniel commented Aug 29, 2019 •

edited

Loading

AlexDaniel commented Aug 29, 2019 •

edited by vrurg

Loading

jnthn commented Aug 29, 2019

AlexDaniel commented Aug 29, 2019 •

edited by vrurg

Loading

vrurg commented Aug 29, 2019

jnthn commented Aug 29, 2019

vrurg commented Aug 29, 2019 •

edited

Loading

vrurg commented Aug 30, 2019 •

edited

Loading

vrurg commented Aug 30, 2019

AlexDaniel commented Aug 30, 2019

vrurg commented Aug 31, 2019

vrurg commented Sep 1, 2019

vrurg commented Sep 2, 2019

AlexDaniel commented Sep 6, 2019

vrurg commented Sep 6, 2019

AlexDaniel commented Oct 3, 2019

[WIP] Blin 2019-08-20 #3132

[WIP] Blin 2019-08-20 #3132

Comments

AlexDaniel commented Aug 22, 2019 • edited Loading

AlexDaniel commented Aug 22, 2019

salortiz commented Aug 22, 2019

AlexDaniel commented Aug 22, 2019

AlexDaniel commented Aug 29, 2019 • edited Loading

AlexDaniel commented Aug 29, 2019 • edited by vrurg Loading

jnthn commented Aug 29, 2019

AlexDaniel commented Aug 29, 2019 • edited by vrurg Loading

vrurg commented Aug 29, 2019

jnthn commented Aug 29, 2019

vrurg commented Aug 29, 2019 • edited Loading

vrurg commented Aug 30, 2019 • edited Loading

vrurg commented Aug 30, 2019

AlexDaniel commented Aug 30, 2019

vrurg commented Aug 31, 2019

vrurg commented Sep 1, 2019

vrurg commented Sep 2, 2019

AlexDaniel commented Sep 6, 2019

vrurg commented Sep 6, 2019

AlexDaniel commented Oct 3, 2019

AlexDaniel commented Aug 22, 2019 •

edited

Loading

AlexDaniel commented Aug 29, 2019 •

edited

Loading

AlexDaniel commented Aug 29, 2019 •

edited by vrurg

Loading

AlexDaniel commented Aug 29, 2019 •

edited by vrurg

Loading

vrurg commented Aug 29, 2019 •

edited

Loading

vrurg commented Aug 30, 2019 •

edited

Loading