Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backcompat for the exception thrown when construction a hash is no longer working #3263

Closed
AlexDaniel opened this issue Oct 23, 2019 · 0 comments · Fixed by #3265
Closed

Backcompat for the exception thrown when construction a hash is no longer working #3263

AlexDaniel opened this issue Oct 23, 2019 · 0 comments · Fixed by #3265
Labels
6.c Related to the next 6.c language release BLOCKER Preventing the next release of rakudo, or just needing attention before the release

Comments

@AlexDaniel
Copy link
Contributor

This 6.c-errata tests is failing when using rakudo master:
https://github.com/perl6/roast/blob/de5f71b58777bbbfd8aedd61632481f2dd2c5edc/S04-declarations/constant.t#L39

IRC discussion starts here: https://colabti.org/irclogger/irclogger_log/raku-dev?date=2019-10-23#l161

Basically:

<vrurg> Spec changes. 6.c was reporting X::TypeCheck, 6.d turned it into correct exception type.

So it should give X::TypeCheck on v6.c and X::Hash::Store::OddNumber on v6.d, but it's no longer the case, or so it seems.

Also, this related commit should probably be reverted.
@AlexDaniel AlexDaniel added BLOCKER Preventing the next release of rakudo, or just needing attention before the release 6.c Related to the next 6.c language release labels Oct 23, 2019
vrurg added a commit to vrurg/rakudo that referenced this issue Oct 23, 2019
@vrurg
Preserve compiler version in EVALs
0eea939 
Previously it was always reset to the default one.

Fixes rakudo#3263
@vrurg vrurg mentioned this issue Oct 23, 2019
Merged
vrurg added a commit to Raku/roast that referenced this issue Oct 23, 2019
@vrurg
Add test for EVAL preserving caller's compiler version
f9aca25 
Support for rakudo/rakudo#3265,

Related to rakudo/rakudo#3263
@vrurg vrurg mentioned this issue Oct 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.c Related to the next 6.c language release BLOCKER Preventing the next release of rakudo, or just needing attention before the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve compiler version in EVALs vrurg/rakudo
1 participant
@AlexDaniel