Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inch IO::Path closer to the recent spec changes (path, volume, Str) #126

Merged
merged 1 commit into from Apr 17, 2013

Conversation

@labster
Copy link
Member

commented Apr 15, 2013

Start to support .volume (though eventually we'll need File::Spec for that)

.Str now returns full path, .path now returns self. IO::FileTestable changed to work with that.

@moritz

This comment has been minimized.

Copy link
Member

commented Apr 15, 2013

I fear that the ".Str now returns full path, .path now returns" part will break File::Tools (or whatever it's called), and thus panda. Have you check that?
If yes, we need an intermediate step: a method like .fullpath which returns the full path, and which those modules can use now, and a deprecation notice in file docs/deprecations. Then we can update those modules in due time, and change the .Str and .path methods after the next Rakudo release.

@labster

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2013

Panda runs locally and passes all of its tests, and so do File::Find and Shell::Command.

File::Find uses .basename, and seems to be designed to work around limitations in IO::Path in the first place.

@labster

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2013

I'd also like to note that a path object stringifies to what .path used to be, so the new .path should not be too surprising. This is why roast for io-path still passes -- though I will need to fix the tests for dir(). And add lots more tests, while I'm at it.

.Str changing is more likely to be a surprise, but the spec change was announced more than 2 weeks ago, which I hope is long enough.

moritz added a commit that referenced this pull request Apr 17, 2013
Merge pull request #126 from labster/nom
inch IO::Path closer to the recent spec changes (path, volume, Str)

@moritz moritz merged commit 02b7524 into rakudo:nom Apr 17, 2013

@MasterDuke17 MasterDuke17 referenced this pull request Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.