RT#102994: State init vars if not set on first pass #1539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the following subroutine:
sub f($x) {
return if $x;
state $y = 5;
$y;
}
Previously, $y would only be assigned a value if the statement is
reached on the first invocation of the static frame.
To address this, added an indicator on the static frame (in
corresponding MoarVM development) and modified p6stateinit to take a var
and check whether it has been assigned to. If the assignment was not
reached in the first pass in the life of a static frame, the is_hll_init
value indicates that it requires HLL assignment the next time it is
encountered.
See [RT#102994](https://rt.perl.org/Public/Bug/Display.html?id=102994)
Modify p6stateinit to match the functionality of the MoarVM version.
|
Relies on changes made in MoarVM/MoarVM#805 and Raku/nqp#418. This change passes all the tests in the (MoarVM) spectest except one: which I assume is because of the modification to the MVMStaticFrame struct. I don't know how to update this test. |
This was referenced Feb 17, 2018
jstuder-gh
added a commit
to jstuder-gh/roast
that referenced
this pull request
Feb 17, 2018
See [RT#102994](https://rt.perl.org/Public/Bug/Display.html?id=102994) [Rakudo PR#1539](rakudo/rakudo#1539)
|
This is not going to work (See MoarVM PR#805). Closing this now. I'll submit another PR at a later date if I create something that addresses the entire issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following subroutine:
Previously,
$ywould only be assigned a value if the statement isreached on the first invocation of the static frame. So if
f(1)is called first,each subsequent
f(0)call returns(Any)To address this, added an indicator on the static frame (in
corresponding MoarVM/JVM developments) and modified
p6stateinitto take a varand check whether it has been assigned to. If the assignment was not
reached in the first pass in the life of a static frame, the is_hll_init
value indicates that it requires HLL assignment the next time it is
encountered.
See RT#102994