Allow UInt to return a failure from Int #3289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still not sure I understand what problem this is fixing? Could you provide some example code, that could be used in a test? |
|
@lizmat I think it's the following case: The patch bypasses the |
|
Thank you @vrurg, that is indeed the issue being addressed. |
lizmat
added a commit
that referenced
this pull request
Nov 8, 2019
Inspired by Daniel Mita++ in PR in #3289. The original Failure of not being able to convert "a" to a number, is now returned, rather than being thrown by the check whether the value is negative.
|
@mienaikage: thank you for this Pull Request. I've taken the liberty to address the problem in another way in 8f30cc7 . Please do keep those PR's coming! Related: it would be very nice if you could create a PR to test the fix! |
vrurg
pushed a commit
to vrurg/rakudo
that referenced
this pull request
Nov 23, 2019
Inspired by Daniel Mita++ in PR in rakudo#3289. The original Failure of not being able to convert "a" to a number, is now returned, rather than being thrown by the check whether the value is negative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int can give a failure for e.g.
X::Str::Numeric, which results in an exception when used with< 0. This is to check that$gotactually contains an Int before checking that it is not negative.