Improve smartmatching against Mu/Any/Junction #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smartmatching of Mu.new against Mu itself would throw before. This fixes that, but causes problems with smartmatching with junctions.
The last commit breaks smartmatching for junctions. While the compiler could handle their threading when smartmatching, this would break any existing code that has ACCEPTS candidates for junctions. Giving it a default ACCEPTS candidate allows existing code to work again. While not strictly necessary for this to work, this also moves handling of junction smartmatching from Any to Mu. This allows `any(Mu, Any) ~~ Mu` to return `True` instead of `False`.
lizmat
approved these changes
Apr 10, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows any instance to typecheck against any type object by giving
MuanACCEPTScandidate forMu. This alone breaks smartmatching with junctions, though. To fix this, rather than implicitly autothreading junctions with anAny:Ucandidate, threading of junctions is now explicitly handled from aMu:Ucandidate. While it's not strictly necessary for this to reside inMu, this allowsany(Mu, Any) ~~ Muto returnTrueinstead ofFalse, which I feel is more correct. A bonus to doing all this is smartmatching with junctions is now around twice as fast, and there should be a speedup of some form for all smartmatches since someACCEPTScandidates inMu,Any, andJunctionare no longer necessary!Passes
make testandmake spectest.