Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve smartmatching against Mu/Any/Junction #3614

Merged
merged 2 commits into from May 13, 2020
Merged

Improve smartmatching against Mu/Any/Junction #3614

merged 2 commits into from May 13, 2020

Commits on Apr 10, 2020

  1. Allow typechecking of any instance against Mu 

    Smartmatching of Mu.new against Mu itself would throw before. This fixes
that, but causes problems with smartmatching with junctions.
    @Kaiepi
    Kaiepi committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    3b4794f View commit details
    Browse the repository at this point in the history

  2. Improve smartmatching with junctions 

    The last commit breaks smartmatching for junctions. While the compiler
could handle their threading when smartmatching, this would break any
existing code that has ACCEPTS candidates for junctions. Giving it a
default ACCEPTS candidate allows existing code to work again.

While not strictly necessary for this to work, this also moves handling
of junction smartmatching from Any to Mu. This allows `any(Mu, Any) ~~
Mu` to return `True` instead of `False`.
    @Kaiepi
    Kaiepi committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    840d3e8 View commit details
    Browse the repository at this point in the history